add search feature in listing issues#3196
Conversation
mislav
left a comment
There was a problem hiding this comment.
Looks like a nice start! Can --search be combined with other flags, like --label or --assignee? If it can, then shouldn't we add those search clauses to the search query?
Can --search be combined with --web? I do not see why not, but some code will have to be moved around for that.
|
@mislav Would Oh yes |
|
@g14a Well, unless otherwise stated, I think that different flags on the same command should generally combine well with each other. For example, if I'm already familiar with |
|
@mislav That's actually a good idea to not force the user to use a different flag all of a sudden and forget his older familiarity. Okay so you propose we combine the results of multiple flags and present them as one whole result set. Correct me if I'm wrong? |
|
@mislav I've combined the rest of the flags with Search has been combined with I'd like some feedback on this :) |
This comment has been minimized.
This comment has been minimized.
|
@mislav I've tried to improve the PR with your feedback and wrote new tests separately for |
mislav
left a comment
There was a problem hiding this comment.
This looks so much better! Only minor polish pieces remaining
|
@mislav I've completed the minor polish pieces. Thanks for the assistance! |
d0b081f to
34680a5
Compare
mislav
left a comment
There was a problem hiding this comment.
Fantastic. I've pushed some tweaks and a major restructuring of the tests, but overall, this works great!
samcoe
left a comment
There was a problem hiding this comment.
Left one naming comment, but overall this looks great! Nice job!
174d40b to
ef93ba2
Compare
ef93ba2 to
179d3f0
Compare
|
Thank you @g14a for all the hard work! |
This commit adds a
--searchflag togh issues listwhich uses the Search API. This isn't final. Just an initial trial on the implementation, needs changes and is open to feedback.Implements a filtering option in #641