Avoid crash in pr merge when the pull request has no commits#3036
Merged
Avoid crash in pr merge when the pull request has no commits#3036
pr merge when the pull request has no commits#3036Conversation
A PR is not guaranteed to have commits, it seems, so add a guard against assuming that there is always a head commit.
We relied too much on stubs for these methods. These new tests actually invoke `git` commands in the context of a test repository.
vilmibm
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk of the changes is restructuring tests so this case is easier to test for.
Fixes #3031
Regression from #2255