Conversation
mislav
reviewed
Feb 23, 2021
| Use: "close {<number> | <url> | <branch>}", | ||
| Use: "close [<number> | <url> | <branch>]", | ||
| Short: "Close a pull request", | ||
| Args: cobra.ExactArgs(1), |
Contributor
There was a problem hiding this comment.
This might have not been apparent, but we wanted to force the user to explicitly supply the argument to close instead of taking the current PR implicitly. This made it harder to close the current PR by accident, even though it was inconsistent with other pr commands where the argument was optional.
| Use: "reopen {<number> | <url> | <branch>}", | ||
| Use: "reopen [<number> | <url> | <branch>]", | ||
| Short: "Reopen a pull request", | ||
| Args: cobra.ExactArgs(1), |
Contributor
There was a problem hiding this comment.
Same as close: we wanted to force the explicit argument because of the destructiveness of close/reopen.
Contributor
Author
|
@mislav Thanks for the context around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this PR I went through and normalized all relevant PR command arguments. They should now be consistent across the whole set. They all will take 0 or 1 arguments, where 0 means we will determine the PR from the currently checked out git branch.
closes #3003