Merged
Conversation
vilmibm
suggested changes
Feb 18, 2021
Contributor
Author
|
@vilmibm I've resolved your comments and updated the PR. |
Contributor
Author
|
Anything else to be done? @vilmibm |
TenebrisVulpes
approved these changes
Feb 23, 2021
TenebrisVulpes
approved these changes
Feb 23, 2021
TenebrisVulpes
approved these changes
Feb 23, 2021
TenebrisVulpes
approved these changes
Feb 23, 2021
TenebrisVulpes
approved these changes
Feb 23, 2021
vilmibm
previously requested changes
Feb 23, 2021
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
Looking much better and almost there!
I left some suggestions and my final request is to remove the ability to add new files when a specified file doesn't exist.
Contributor
Author
|
Followed your suggestions @vilmibm and updated the PR. |
Contributor
Author
|
Followed your suggestions @vilmibm and updated the PR. |
Contributor
Author
|
Anything else to be done here? @vilmibm |
Right now the `gist edit` command doesn't write anything to stdout, so let's keep it that way until we want to intentionally provide some feedback in the terminal.
mislav
approved these changes
Feb 27, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thank you for all your work!
This looks good to me. I've pushed some polish changes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds functionality to add files to an existing gist. Add files with absolute path, relative path, files present in the current working directory and new files from stdin.
Closes #2903