Conversation
Contributor
billygriffin
left a comment
There was a problem hiding this comment.
Thanks for the PR @redreceipt! I think we should conditional this based on whether the setting you referenced in your issue is checked. If it's not a blocker to merging, I don't think it deserves the same level of prominence that checks status and approval status do. Thoughts on making this only display for repos that require a branch to be up to date prior to merging?
Contributor
Author
|
Yea I think I agree. Hopefully, the API has that info 😂 |
Contributor
Author
|
ok @billygriffin take a look at this |
vilmibm
approved these changes
Feb 16, 2021
This was referenced Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows whether the current head branch is behind the base branch similar to the web GUI.
Uses the preview API here: https://docs.github.com/en/graphql/reference/enums#mergestatestatus
Closes #2945