Conversation
samcoe
commented
Feb 10, 2021
396d382 to
b7bbce5
Compare
Merged
mislav
approved these changes
Feb 12, 2021
| func EditableSurvey(editorCommand string, options *EditableOptions) error { | ||
| if options.TitleEdited { | ||
| title, err := titleSurvey(options.TitleDefault) | ||
| func (e Editable) TitleParam() *githubv4.String { |
Contributor
There was a problem hiding this comment.
Slight code smell: the Editable type seems tightly coupled to the githubv4 library here. Ideally, it should be agnostic to the transport layer and only converted to appropriate types when the GraphQL query is constructed
Contributor
Author
There was a problem hiding this comment.
Agreed. I will look into ways to decouple them in #2949.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
pr editcommand allowing the ability to edit a pull request after it has been created. There are some small changes to theissue editcommand due to refactoring and renaming in the sharededitablecode.closes #1349
follow ups #2949