Conversation
samcoe
left a comment
There was a problem hiding this comment.
Do we want to mention the docs (https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) for further information?
Also, should we include Resolves in the list of verbs that will automatically close an issue?
|
@samcoe All good questions! I'm not sure if I want to list all the possible keywords, since the sentence might become large. I thought that just listing "Fixes" and "Closes" would be enough. It's a good idea to link to the docs as you suggested, but I wonder whether the link is a bit long to include in our help output? It's 97 characters long, and we try to keep the docs ~80 characters wide. /cc @ampinsk for thoughts |
|
Yeah, I wish adding links was easier but I think it's best to keep this helpful but concise. I think it's good as is 👍 |
Fixes #2879