Allow editing commit msg when squash merging a PR#2896
Allow editing commit msg when squash merging a PR#2896cristiand391 wants to merge 9 commits intocli:trunkfrom
Conversation
|
Tests passed both locally and on my fork: https://github.com/cristiand391/cli/runs/1814289277 |
276acc8 to
15fd3e4
Compare
15fd3e4 to
792bd66
Compare
792bd66 to
3d6aa69
Compare
samcoe
left a comment
There was a problem hiding this comment.
It looks like the tests were failing due to not being up to date with trunk and some conflicting changes had been merged in. I rebased trunk, resolved the tests, and added a bit of polish. I think this is good to go now 👍
|
I've pushed some changes to address suggestions 👍🏾 |
api/queries_pr.go
Outdated
There was a problem hiding this comment.
This query looks good for github.com, but this field is not available in GitHub Enterprise 2.22 or lower, and we support those as well. Adding this field would break all pull request queries on GHE.
We have a mechanism for detecting whether a GraphQL field is supported on the remote. I will take over this PR from here and make the query safe for different hosts. In the meantime I will mark the PR as "changes requested" to block merging.
Thank you for all your contribution so far!
|
@cristiand391 I'm folding your PR into this one that adds auto-merge functionality: #2980 |
Closes #1023
This PR adds support for editing the commit message when squash merging a PR.
Spec: #1023 (comment)
The GraphQL API fails when trying to merge a PR with
authorEmailfield set, so I avoided adding it for now, would be great if anyone in thecliteam can help reporting this to GitHub.https://github.community/t/graphql-api-fails-when-trying-to-merge-a-pull-request-with-authoremail-field-set/158421