remove gist description from single file raw view (#2886)#2888
Merged
remove gist description from single file raw view (#2886)#2888
Conversation
mislav
suggested changes
Feb 1, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
This looks good! A couple of tweaks would still be needed.
In single-file mode, since we no longer need newlines to separate contents of different files, could we avoid printing \n\n below?
out += fmt.Sprintf("%s\n\n", content)
Contributor
Author
fixed |
- Separate out logic to render a single file - Render directly to stdout instead of to string slice - Normalize whitespace between files; ensure no excessive trailing whitespace - Add terminal pager support - Sentence-case for flags
mislav
approved these changes
Feb 2, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Fantastic! Thank you for the updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this closes #2886