Skip to content

Fix secret set --repos for repositories that have dashes#2844

Merged
vilmibm merged 1 commit intotrunkfrom
secret-set-fix
Jan 25, 2021
Merged

Fix secret set --repos for repositories that have dashes#2844
vilmibm merged 1 commit intotrunkfrom
secret-set-fix

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Jan 25, 2021

A GraphQL alias cannot contain dashes. Instead, generate safe identifiers for GraphQL aliases.

Fixes #2829

A GraphQL alias cannot contain dashes. Instead, generate safe
identifiers for GraphQL aliases.
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

@vilmibm vilmibm merged commit e9afac9 into trunk Jan 25, 2021
@vilmibm vilmibm deleted the secret-set-fix branch January 25, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh secret set fails if repository name contains '-' with 'GraphQL error: Parse error on "-"'

2 participants