Conversation
This is to enable build tasks on Windows.
samcoe
left a comment
There was a problem hiding this comment.
I am not super familiar with Make and all its functionality that we are trying to replicate so I will refrain from approving, but from a code standpoint this looks good to me. I left one question.
|
|
||
| func sourceFilesLaterThan(t time.Time) bool { | ||
| foundLater := false | ||
| _ = filepath.Walk(".", func(path string, info os.FileInfo, err error) error { |
There was a problem hiding this comment.
Will this work properly if the script is not run from the root directory? Is that a case we need to handle here?
There was a problem hiding this comment.
That's a good point! Originally, running make from a project directory other than root wouldn't work because there wouldn't be a Makefile there, but now that our build process is an ordinary Go script, it makes sense to add a guard that it must be run from a certain directory. I will add something like that.
Makefiles cam be arcane, but the basic functionality that I'm trying to replicate here is its mechanism of file dependencies. Consider this example: bin/gh: src/foo.go src/bar.go
touch bin/ghThis defines a task for "building" The idea of this PR is, if there are common build tasks that anyone developing on GitHub CLI can benefit from, regardless of platform, we should implement them in Go rather than via Makefile. On the other hand, some tasks only make sense to remain in Makefile, for example Finally, some of our old tasks are "internal" to our team, meaning that they're not useful to any outside contributors. Those tasks are: |
PaulinaParangerHr
left a comment
There was a problem hiding this comment.
Super Ultrasoud
Fast flexibility Is needed these days....
Jumping Creativity...
Access priority ....
Experimental tasks for better
Future
Kind regards
This is to enable build tasks on Windows.
Fixes #2745