Closed
Conversation
17028a6 to
0155627
Compare
Author
|
Looks like i've got some tests to fix :D Will get on those. |
0155627 to
e8184c3
Compare
Kamarulzamansalehudin
approved these changes
Dec 15, 2020
Contributor
|
This is good work, but it has convinced us that we'd like to just switch fully over to the search API endpoints so that we can unlock even more filtering along these lines. We'd rather wait and make that switch all at once instead of conditionally using it for some queries and not others. Thanks for patience while we plan for that 🙏 |
Author
|
Thanks for the explanation @vilmibm 🙏 No worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports #1119
This adds support for:
I tried to follow along with the discussions in that Issue thread. This appears to work for my use-case, not sure if I am missing something or if using the
searchAPI is not the way to go.Just thought I would throw this out there incase ✌️