Closed
Conversation
12 tasks
mislav
suggested changes
Nov 30, 2020
| promptString = fmt.Sprintf("This will create '%s/%s' and add it as remote for your current directory. Continue? ", repoOwner, repoName) | ||
| } else { | ||
| promptString = fmt.Sprintf("This will create '%s' in your current directory. Continue? ", repoName) | ||
| promptString = fmt.Sprintf("This will create '%s' and add it as remote for your current directory. Continue? ", repoName) |
Contributor
There was a problem hiding this comment.
This error message will be accurate for the mode when repo create is running within the context of a git repo, but will not be accurate when repo create is running outside of a local git repo. In the latter case, there will be an additional prompt to optionally clone the new repository in a subdirectory. See #1913
I'm not sure what the solution should be. Please let us discuss this with our team first and get back to you. 🙇
Contributor
|
Thanks for this! We're planning a full overhaul of the repo create command, so we're closing these more piecemeal improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I read the message I thought the command would create a new directory for the new repository in my current directory. I think the message should make clear that no new directory is created, but the new GitHub repository is added as remote
originto the current directory's git repo.If anyone has better suggestions for formulating this in a concise way, I'm happy to change the wording in this PR.