[#1755] SSH key management (gh ssh-key list)#1862
Conversation
mislav
left a comment
There was a problem hiding this comment.
Hi, thank you for the thorough implementation! The code looks solid at cursory glance.
However, I won't be fully reviewing this PR nor approving it at the moment because, per our CONTRIBUTING policy, we currently don't accept PRs for features that our team hasn't discussed and explicitly approved. Right now, we haven't reached a decision about ssh-key management being included in gh.
In the meantime, you may use your fork or gh api to manage ssh-keys. 🙇
|
@mislav Alright, no problem. I have learned a lot implementing this feature, thank you for your recognition 😄 So, this PR will be closed? Or, can we wait for the team decision? |
|
We haven't done feature prioritization yet for a post-1.0 release, so let's keep this open until we do, if you don't mind (a couple of weeks tops). |
|
🤪 |
Do not require nor request `read:public_key` scope by default.
There was a problem hiding this comment.
Thank you for your contribution! I have pushed a change to vastly simplify the implementation and change the output format to a table-based one for consistency with other commands.
Additionally, we won't request read:public_key scope by default. The user can choose to add that scope if they wish to use the ssh-key list command.
Command
gh ssh-key listimplemented.This feature request can be accessed by #1755 tag.
✅ Command
gh ssh-key list- That shows all of the currently SSH-KEY and names.✅ Test coverage 98%+