I'm not sure if we need this final confirmation if there was a prompt before this. Two prompts make it look as if the user is potentially doing something really dangerous. The worst thing that can happen to a user that has accidentally logged out is that they will have to go through the OAuth flow again when they want to use gh next, which usually takes under a minute.

So if the user typed out gh auth logout and selected a hostname from a list, I think we can assume that they want to logout from that host without any additional safety nets. Thoughts @ampinsk?

Chatted with @ampinsk in our sync and for now we'll leave the confirmation in ✨

Not necessarily something that you have to address here, but I was thinking: now that we have the ability to pass a mock Config when testing a command, and Config is an interface, we could pass our own test stub that conforms to that interface and that verifies that Write was called, but does not actually attempt to write to disk. That way we don't have to rely on package-level function stubbing anymore.

I'm in favor of reducing package-level function stubbing for sure; here, I like that we're exercising the the part of Write that is taking the yaml tree and actually writing it out. There's just enough logic in there that I'd feel better having coverage for it. I assume we can refactor to have the best of both worlds but I'm not in any rush to do it.

here, I like that we're exercising the the part of Write that is taking the yaml tree and actually writing it out.

For sure! If Write isn't exercised anywhere else in tests, then it's great to keep it active here. 👍