Skip to content

Enable extended PR screening for external PRs#13312

Merged
tidy-dev merged 1 commit into
trunkfrom
enable-pr-screening
Apr 30, 2026
Merged

Enable extended PR screening for external PRs#13312
tidy-dev merged 1 commit into
trunkfrom
enable-pr-screening

Conversation

@tidy-dev

@tidy-dev tidy-dev commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Opts in to the new PR screening features in the shared triage workflow:

  • Instantly closes PRs with zero file changes
  • Detects same-author resubmissions of recently closed PRs
  • Fast-tracks small, well-described fixes to ready-for-review
    • This one I am leery of having many false positives so would like to hear feedback from the team if we want to turn it off if we are finding it to be too lenient after trying it out. I think could be the best candidate for and iteration of adding agentic analysis
  • Accelerates closure of large unsolicited PRs (2 days vs 7)
  • Updates regular unmet requirements time to close to 4 days/

Depends on desktop/gh-cli-and-desktop-shared-workflows#17

Opts in to the new PR screening features in the shared triage workflow:
- Instantly closes PRs with zero file changes
- Detects same-author resubmissions of recently closed PRs
- Fast-tracks small, well-described fixes to ready-for-review
- Accelerates closure of large unsolicited PRs (3 days vs 7)

Depends on desktop/gh-cli-and-desktop-shared-workflows#17

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables the new “extended PR screening” behavior in the shared PR triage workflow by opting in via reusable-workflow inputs, including customized auto-close timings.

Changes:

  • Opts triage-pr-requirements.yml into PR screening via enable_pr_screening: true.
  • Configures close timeouts for general PRs and “large PRs” on both event-driven and scheduled runs.
Show a summary per file
File Description
.github/workflows/triage-pull-requests.yml Passes new screening/timeout inputs to the shared triage reusable workflow for both live PR events and the daily scheduled job.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

.github/workflows/triage-pull-requests.yml:48

  • Same as above: these timeout values (4 days / 2 days) differ from what the PR description claims (3 days / 7 days). Please align the workflow inputs and the PR description to avoid confusion about the triage behavior on the scheduled run.
      enable_pr_screening: true
      days_until_close: 4
      large_pr_days_until_close: 2
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread .github/workflows/triage-pull-requests.yml
@tidy-dev tidy-dev merged commit 611b01f into trunk Apr 30, 2026
62 checks passed
@tidy-dev tidy-dev deleted the enable-pr-screening branch April 30, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants