ci: enable noop linters #12440
Merged
ci: enable noop linters #12440
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the golangci-lint configuration by enabling additional "noop" linters (linters that don't produce errors in the current codebase). The configuration has been reorganized to include inline documentation describing each linter's purpose.
- Adds 12 new linters to catch potential issues: asasalint, asciicheck, bidichk, exptostd, fatcontext, gocheckcompilerdirectives, gochecksumtype, gomoddirectives, goprintffuncname, nosprintfhostport, reassign, and unused
- Maintains all 8 previously enabled linters: bodyclose, copyloopvar, durationcheck, gocritic, govet, ineffassign, nilerr, and nolintlint
- Adds descriptive inline comments for each linter to improve configuration maintainability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Babak K. Shandiz <babakks@github.com>
BagToad
approved these changes
Jan 7, 2026
Member
BagToad
left a comment
There was a problem hiding this comment.
LGTM - makes sense to start with noop linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12439