ci: tag per build job #12428
Merged
ci: tag per build job #12428
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to tag the HEAD commit to make sure the right version is baked into the built binaries. See for more details: - #12263 Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a false positive CVE detection issue (CVE-2024-52308) in Trivy scans by ensuring the correct version information is embedded in built binaries. The problem occurred because binaries were showing pseudo-versions like v2.0.0-20251104174640-152d328db80d instead of proper release tags, causing Trivy to incorrectly flag them as vulnerable versions.
- Adds local git tag creation before each build job to embed proper version information in binaries
- Applies the fix consistently across all three build platforms (Linux, macOS, Windows)
- The tags are created locally only and not pushed to the remote repository
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12263
With this PR we tag the HEAD commit (per build job) to make sure the right version is baked into the built binaries.