Skip to content

Conversation

@williammartin
Copy link
Member

@williammartin williammartin commented Dec 11, 2025

This PR bumps sigstore-go to v1.1.4, and also upgrades the go-licenses tool to v2.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates sigstore-go dependency from an earlier version to v1.1.4, which involves removing numerous third-party dependency files and license files as part of the dependency update process.

Reviewed changes

Copilot reviewed 158 out of 1101 changed files in this pull request and generated no comments.

File Description
Multiple third-party LICENSE files Removed license files for various dependencies including hashicorp/golang-lru, hashicorp/go-version, in-toto packages, and many others
Multiple third-party test files Removed test files from hashicorp/golang-lru and hashicorp/go-version packages
Multiple third-party source files Removed source code files from hashicorp packages including LRU cache implementations and version handling utilities
Multiple third-party configuration files Removed go.mod files, CI configuration files, and other build/development configuration files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@williammartin williammartin force-pushed the wm/bump-sigstore-go branch 2 times, most recently from 0eae7ef to 19b1b7b Compare December 11, 2025 15:30
@chrisahl
Copy link

chrisahl commented Jan 7, 2026

Will this PR or #12299 be merged soon?

@babakks
Copy link
Member

babakks commented Jan 7, 2026

IIRC we faced an issue with our third-party license management tool when doing this. I can prioritise it, unless @williammartin has something ongoing on it.

Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
@babakks babakks force-pushed the wm/bump-sigstore-go branch from 03522e9 to 7925d73 Compare January 7, 2026 15:22
williammartin and others added 3 commits January 7, 2026 15:38
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Copy link
Member

@BagToad BagToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @babakks

@babakks babakks merged commit d817414 into trunk Jan 7, 2026
11 checks passed
@babakks babakks deleted the wm/bump-sigstore-go branch January 7, 2026 17:00
@chrisahl
Copy link

chrisahl commented Jan 7, 2026

Thanks for the fixes. I have not found info yet on how often a new version is released, do you know when a new version will appear or what determines when a new version is created?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants