Skip to content

Conversation

@rneatherway
Copy link
Contributor

@rneatherway rneatherway commented Nov 4, 2025

Description

Fixes #12249

I've wanted this a few times recently and it seems like a reasonable addition in keeping with the other flags.

@rneatherway rneatherway marked this pull request as ready for review November 4, 2025 14:44
@rneatherway rneatherway requested a review from a team as a code owner November 4, 2025 14:44
@rneatherway rneatherway requested a review from babakks November 4, 2025 14:44
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Nov 4, 2025
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

Copy link
Member

@babakks babakks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @rneatherway! 🍻

LGTM, except for missing tests. Can you please add the tests? You can basically replicate the Wiki flag tests.

@rneatherway
Copy link
Contributor Author

LGTM, except for missing tests. Can you please add the tests? You can basically replicate the Wiki flag tests.

No problem, done.

Copy link
Member

@babakks babakks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix! 🍻

@babakks
Copy link
Member

babakks commented Dec 11, 2025

Merging as the failed workflow has nothing to do with this PR (it's about unfixed vulnerability in github.com/sigstore/timestamp-authority).

@babakks babakks merged commit adbc717 into cli:trunk Dec 11, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --actions flag to gh browse

3 participants