fix(auth): respect http_unix_socket during auth flow #11890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http.Client used during OAuth authentication was not configured to use the 'http_unix_socket' value from the user's config. This caused authentication to fail for users who rely on a Unix socket for HTTP traffic. This commit fixes the issue by creating a shared api.NewPlainHTTPClient that correctly configures the transport to use the Unix socket if one is specified. This new function is now used in both the auth flow and auth refresh commands, ensuring consistent behavior. Additionally, this resolves an issue where the wrong Accept header was being sent during the OAuth device flow, which resulted in an HTTP 406 error.
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
Member
|
Thanks for the PR, but I'm closing this as I've already explained in #11891 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybesfixes #11891 ?
The http.Client used during OAuth authentication was not configured to use the 'http_unix_socket' value from the user's config. This caused authentication to fail for users who rely on a Unix socket for HTTP traffic.
This commit fixes the issue by creating a shared api.NewPlainHTTPClient that correctly configures the transport to use the Unix socket if one is specified. This new function is now used in both the auth flow and auth refresh commands, ensuring consistent behavior.
Additionally, this resolves an issue where the wrong Accept header was being sent during the OAuth device flow, which resulted in an HTTP 406 error.
This should be reviewed skeptically because: