gh agent-task view: display session error if any
#11763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
BagToad
reviewed
Sep 18, 2025
BagToad
reviewed
Sep 18, 2025
BagToad
reviewed
Sep 18, 2025
Signed-off-by: Babak K. Shandiz <babakks@github.com>
…dAt` Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
update agents resource route
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
BagToad
reviewed
Sep 19, 2025
Comment on lines
+321
to
+328
| // Note that when the session is just created, a PR is not yet available for it. | ||
| if session.PullRequest != nil { | ||
| fmt.Fprintf(opts.IO.Out, "\n%s%s • %s\n", | ||
| session.PullRequest.Repository.NameWithOwner, | ||
| cs.ColorFromString(prShared.ColorForPRState(*session.PullRequest))(fmt.Sprintf("#%d", session.PullRequest.Number)), | ||
| cs.Bold(session.PullRequest.Title), | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
Not doing it in this PR: but I had a thought about whether we should show a "awaiting PR" type of message for this case. It probably won't happen much, so not concerned about it. Just an idea.
BagToad
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the session error, if any, in the overview mode.
Also the in prompt when there are multiple sessions are now a bit different. Before, it was like:
But now, I had to change it to: