Skip to content

fix error for ErrReleaseNotFound when fetching ref #11451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejahnGithub merged 2 commits into from
Aug 8, 2025
Merged

fix error for ErrReleaseNotFound when fetching ref #11451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1beb825
fix error for ErrReleaseNotFound when fetching ref
ejahnGithub Aug 5, 2025
82eb05b
Merge branch 'trunk' into eugene/fetch-ref-handle-ReleaseNotFound
ejahnGithub Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cmd/release/shared/fetch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ func FetchRefSHA(ctx context.Context, httpClient *http.Client, repo ghrepo.Inter
} `json:"object"`
}
if err := json.NewDecoder(resp.Body).Decode(&ref); err != nil {
return "", err
// release not found
return "", ErrReleaseNotFound
Copy link
Member

@babakks babakks Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also affects other release subcmds. I agree with CCR in that this error can have other reasons.

Copy link
Contributor Author

@ejahnGithub ejahnGithub Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When fetching the ref SHA of a tag, a partial semver match returns a 200 response with an empty body, which causes the JSON decode to fail.
For example, if the tag is v1.0.0, only refs/tags/v1.0.0 will work — v1 or v1.0 will return 200 with empty body.

This behavior aligns with other gh release commands, which also require the exact tag name, otherwise would return release not found. Partial semver versions won’t work — only the full, exact tag is accepted.

}

return ref.Object.SHA, nil
Expand Down
Loading