Merged
Conversation
dc76fe0 to
df0756f
Compare
probablycorey
approved these changes
Jun 5, 2020
command/alias.go
Outdated
| return fmt.Errorf("no such alias %s", alias) | ||
| } | ||
|
|
||
| expansion := aliasCfg.Get(alias) |
Contributor
There was a problem hiding this comment.
I was wondering what the return value would be if you didn't check for existence on line 137. This got me thinking about making the Get method work more like the Go map lookup. So the interface would be:
func Get(alias string) (value string, found bool)
This isn't something we have to do, but it feels like it might be more standard Go style.
Contributor
Author
There was a problem hiding this comment.
that would make sense 👍
| content := cm.Root.Content | ||
| for i := 0; i < len(content); i++ { | ||
| if content[i].Value == key { | ||
| i++ // skip the next node which is this key's value |
Contributor
There was a problem hiding this comment.
This confused me, but I think it's mostly because iterating over YAML nodes is weird. But from what I can find this is just how it works?
Contributor
Author
There was a problem hiding this comment.
sadly yes this is how it works 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #990
This PR adds
gh alias delete <alias>. It's pretty straightforward.Part of #936
See also #989