fix: merging a PR should checkout the base branch, not the default#1095
Closed
fix: merging a PR should checkout the base branch, not the default#1095
Conversation
Contributor
|
Hi @sammarks, thanks for the PR! I think this is a really interesting idea - we ask that contributors create an issue first to discuss and align on a path forward prior to submitting a PR, so could I ask you to do that please? I'm wondering whether others agree with this assumption that the base branch is always better than the default branch, so I'd love to hear from others before we make a call to change it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for making such a great tool!
In my usage, I've found it would be a more convenient default to switch to the base branch of a PR upon merge instead of the default branch for the repository.
Though, I can see how some would prefer to switch to the base branch instead. Happy to open an issue as well and continue any discussion there if need be.
I haven't modified any tests because I didn't see any where the merge command was tested.