-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Closed
Labels
gh-attestationrelated to the gh attestation commandrelated to the gh attestation commandneeds-triageneeds to be reviewedneeds to be reviewed
Description
Per https://github.com/cli/cli/pull/9566/files#r1747278610, there are two tests in the integration tests file that can be moved into a non-integration test file:
cli/pkg/cmd/attestation/verification/sigstore_integration_test.go
Lines 45 to 53 in 82b5099
| t.Run("with missing verification material", func(t *testing.T) { | |
| _, err := GetLocalAttestations("../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-verification-material.jsonl") | |
| require.ErrorContains(t, err, "missing verification material") | |
| }) | |
| t.Run("with missing verification certificate", func(t *testing.T) { | |
| _, err := GetLocalAttestations("../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-cert.jsonl") | |
| require.ErrorContains(t, err, "missing bundle content") | |
| }) |
Metadata
Metadata
Assignees
Labels
gh-attestationrelated to the gh attestation commandrelated to the gh attestation commandneeds-triageneeds to be reviewedneeds to be reviewed