-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Closed
Labels
bugSomething isn't workingSomething isn't workingcoreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributorsgh-prrelating to the gh pr commandrelating to the gh pr commandp2Affects more than a few users but doesn't prevent core functionsAffects more than a few users but doesn't prevent core functions
Description
Describe the bug
When I ran gh pr create --fill I had one commit on the branch with a msg like this:
Testing one, two, three
More details and some paragraphs here.
It looks like the CLI created the PR title with everything up to the first comma:
Testing one
Then the body/description for the PR included the rest of the first line in the body:
two, threeMore details and some paragraphs here.
So it was split after the first comma.
gh version 2.44.1 (2024-02-16)
https://github.com/cli/cli/releases/tag/v2.44.1
This might relate somewhat to this issue although I'm not sure:
#8706
Steps to reproduce the behavior
Create a branch with a single commit that has comma in the first line of the commit message. Then:
gh pr create --fill
Expected vs actual behavior
I would expect the whole first line of the commit message to be used as the subject for the PR. Not just the text up until the first comma.
creachadair, danp and setu4993creachadair
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcoreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributorsgh-prrelating to the gh pr commandrelating to the gh pr commandp2Affects more than a few users but doesn't prevent core functionsAffects more than a few users but doesn't prevent core functions