-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Open
Labels
coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributorsenhancementa request to improve CLIa request to improve CLIgh-runrelating to the gh run commandrelating to the gh run command
Description
Describe the feature or problem you’d like to solve
Given the myriad issues relating to missing logs:
-
gh run view --logdoes not display logs when job names contain characters not allowed in file paths #7640 -
gh run view --logwith duplicate job names incorrectly shows the same log twice #7641 -
gh run view --logdoes not display logs when job names are beyond a certain length #7642
It might be interesting to provide some mechanism to indicate when files in the .zip were not included in the log output. This would help CLI users and maintainers to uncover when there are missing logs, which logs are missing and why.
Proposed solution
I don't have a good idea of how to do this from a UX point of view, perhaps leaning on GH_DEBUG or having another flag would help.
The consequence of whatever setting would be that if files in the .zip were not attached to the runLog we would provide some indication why.
My assumption here is that we know which files in the .zip should be included. I believe we do but I haven't seen all possible directory structures 🤷
Metadata
Metadata
Assignees
Labels
coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributorsenhancementa request to improve CLIa request to improve CLIgh-runrelating to the gh run commandrelating to the gh run command