Skip to content

make install fails in v2.28.0 due to non portable option to 'install' being used #7368

@debohman

Description

@debohman

Describe the bug

make install in v2.28.0 results in the following on my system:

% make DESTDIR=/tmp/dst.gh install
build.go: `bin/gh` is up to date.
go run ./cmd/gen-docs --man-page --doc-path ./share/man/man1/
mkdir -p ./share/bash-completion/completions ./share/fish/vendor_completions.d ./share/zsh/site-functions
bin/gh completion -s bash > ./share/bash-completion/completions/gh
bin/gh completion -s fish > ./share/fish/vendor_completions.d/gh.fish
bin/gh completion -s zsh > ./share/zsh/site-functions/_gh
install -d /tmp/dst.gh/usr/local/bin
install -m755 bin/gh /tmp/dst.gh/usr/local/bin/
install -d /tmp/dst.gh/usr/local/share/man/man1
install -m644 ./share/man/man1/* /tmp/dst.gh/usr/local/share/man/man1/
install -DT -m644 ./share/bash-completion/completions/gh /tmp/dst.gh/usr/local/share/bash-completion/completions/gh
install: illegal option -- D

Expected vs actual behavior

I expected the install to complete without error.

Regression

Issue is not present in v2.27.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds-triageneeds to be reviewed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions