Maintainer PR push access #8794
-
|
Hi, Not sure this is the right place to post, apologies if not! I am a maintainer of a public repository and sometimes get pull-requests. Usually, a user will propose some code update in their PR and before merging, I make minor code updates using cli. The setup typically looks like this: This workflow has been working correctly over the past 6 months but recently, I get stuck at Yet, when I run On the one hand, this seems sensible in view of the github doc, that states:
On the other hand, the PRs have a "Maintainers are allowed to edit this pull request." check (see screenshot below). 
QuestionIs this a bug? Has there been any recent change that may be responsible for that? |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 9 replies
-
|
Everything you're doing looks sensible to me @matthieutrs. That's a surprising error that seems like it is coming from somewhere deep in the stack. If you really didn't have permissions I would expect to see something like:
I've asked for guidance from another team that knows more about the git stack. |
Beta Was this translation helpful? Give feedback.
-
|
Quick question, does this repository make use of |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @williammartin for the very quick response! No, the repository is not using |
Beta Was this translation helpful? Give feedback.
-
|
That's interesting because this error really seems to be coming from Is it possible you ever ran any (my grep is rusty, you might have to look in the file itself!) |
Beta Was this translation helpful? Give feedback.
-
|
Indeed, you are right! I have a Thans a lot @williammartin! 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
Hooray! I'm not sure what else gets installed but |
Beta Was this translation helpful? Give feedback.
-
Wow, I got the same error and it was fixed by removing |
Beta Was this translation helpful? Give feedback.
-
|
Copying from an internal conversation to provide clarity as to what happened here:
|
Beta Was this translation helpful? Give feedback.
-
|
I ran into this over at sinatra/mustermann#145, marked as $ gh pr checkout 145
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 5 (delta 2), reused 5 (delta 2), pack-reused 0 (from 0)
Unpacking objects: 100% (5/5), 696 bytes | 139.00 KiB/s, done.
From github.com:sinatra/mustermann
* [new ref] refs/pull/145/head -> jruby_ci
Switched to branch 'jruby_ci'
$ git rebase main
Successfully rebased and updated refs/heads/jruby_ci.
$ git push --force-with-lease
To github.com:headius/mustermann.git
! [rejected] jruby_ci -> jruby_ci (stale info)
error: failed to push some refs to 'github.com:headius/mustermann.git'
$ grep -rl lfs .git/hooks
$ echo $?
1 |
Beta Was this translation helpful? Give feedback.
-
|
That's interesting! I looked for any help around the Could you please provide me with these details?
Also, can you please confirm that doing what's suggested in the link I mentioned above works for you? I mean, instead of going through git remote add headius git@github.com:headius/mustermann.git
git fetch headius jruby_ci
git checkout jruby_ci
git rebase main
git push --force-with-lease headius jruby_ci |
Beta Was this translation helpful? Give feedback.
-
|
Here we go $ gh version
gh version 2.59.0 (2024-10-15)
https://github.com/cli/cli/releases/tag/v2.59.0
~/src/mustermann main
$ gh pr checkout 145
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 5 (delta 2), reused 5 (delta 2), pack-reused 0 (from 0)
Unpacking objects: 100% (5/5), 703 bytes | 175.00 KiB/s, done.
From github.com:sinatra/mustermann
* [new ref] refs/pull/145/head -> jruby_ci
Switched to branch 'jruby_ci'
~/src/mustermann jruby_ci
$ git config --list --show-origin | grep 'branch\.pr/headius/145'
~/src/mustermann jruby_ci
$ echo $?
1I didn't try to push to the branch because it is up-to-date now. I will also update my GitHub CLI 😇 Thanks |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the details, @dentarg. However, since v2.59.0 there have been lots of changes to the |
Beta Was this translation helpful? Give feedback.
-
|
I'll let you know if there's a problem in the future :) I don't have a situation where I can try again at the moment. Thanks for replying! |
Beta Was this translation helpful? Give feedback.
-
|
FWIW, I was on 2.75.0 and seemed to have an issue but now that I'm on 2.80.0 it seems to work fine. |
Beta Was this translation helpful? Give feedback.
That's interesting because this error really seems to be coming from
LFS.Is it possible you ever ran any
git lfscommand in the repo? This would result in the hooks being set up. Perhaps you could check in your repo.git/hookswhether there is apre-pushcontaining anything relating tolfse.g.(my grep is rusty, you might have to look in the file itself!)