-
|
cli/internal/codespaces/codespaces.go Line 93 in 03730c2 I noticed the listening address format has changed from fmt.Sprintf(":%d", port) to fmt.Sprintf("127.0.0.1:%d", port) since v2.22, and this change made port forwarding broken on macOS 13 (potentially other older version too, will need to double confirm)
I am wondering what's the reason behind this change. Reference: https://pkg.go.dev/net |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 5 replies
-
|
@jasonw-rr Thanks for writing in. Do you know how come the |
Beta Was this translation helpful? Give feedback.
-
|
Oh nice catch! This was a miss from me DRYing up the local server start code into a helper function. I copied the helper from places that used |
Beta Was this translation helpful? Give feedback.
-
|
As far as I know, the privilege port restriction should apply globally regardless which address you bind it with, or at least all non-local addresses (based on my experience) I simply compared the source between the last known working version and the one stopped working, then tested the 2 syntax locally in one single |
Beta Was this translation helpful? Give feedback.
-
|
@cmbrose @jasonw-rr Either of you have time to prepare PR for this? |
Beta Was this translation helpful? Give feedback.
-
|
Already on it: https://github.com/cli/cli/pull/7326/files |
Beta Was this translation helpful? Give feedback.
-
|
Wow, thanks for the prompt response and turnaround! |
Beta Was this translation helpful? Give feedback.
Already on it: https://github.com/cli/cli/pull/7326/files