test(skills): acceptance coverage for nested skills/ discovery

BagToad · Copilot · BagToad · commit d9f030520f82 · 2026-04-20T10:39:16.000-06:00
Add an acceptance test exercising the relaxed skills/ discovery rules:
- direct path-based install of a deeply nested skill
- direct path-based install of a deeply nested namespaced skill
- name-based discovery resolving a deeply nested skill

Fix skills-publish-dry-run negative case: the test's testdata contains
test-repo/skills/hello-world/SKILL.md under $WORK, which is now
discoverable from $WORK due to nested skills/ matching. Point the
'no skills found' assertion at a fresh empty subdirectory so it tests
what it claims to.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/acceptance/testdata/skills/skills-install-nested-discovery.txtar b/acceptance/testdata/skills/skills-install-nested-discovery.txtar
@@ -0,0 +1,66 @@
+# Skills can live in a nested skills/ directory under a path prefix
+# (e.g. <prefix>/skills/<name>/SKILL.md), as used by repositories that
+# organize skills by topic. Both name-based discovery and direct
+# path-based install must work for these layouts.
+
+# Use gh as a credential helper
+exec gh auth setup-git
+
+# Create a repo with skills nested under prefixes
+exec gh repo create $ORG/$SCRIPT_NAME-$RANDOM_STRING --public --add-readme
+defer gh repo delete --yes $ORG/$SCRIPT_NAME-$RANDOM_STRING
+
+exec gh repo clone $ORG/$SCRIPT_NAME-$RANDOM_STRING
+cd $SCRIPT_NAME-$RANDOM_STRING
+
+# Deeply nested skill: <prefix>/skills/<name>/SKILL.md
+mkdir -p group-a/category-x/skills/skill-one
+cp $WORK/skill-one.md group-a/category-x/skills/skill-one/SKILL.md
+
+# Deeply nested namespaced skill: <prefix>/skills/<namespace>/<name>/SKILL.md
+mkdir -p group-b/category-y/skills/team-alpha/skill-two
+cp $WORK/skill-two.md group-b/category-y/skills/team-alpha/skill-two/SKILL.md
+
+exec git add -A
+exec git commit -m 'Add nested skills'
+exec git push origin main
+
+# Publish so the skills are discoverable
+exec gh skill publish --tag v1.0.0
+
+# Install the deeply nested skill by direct path
+exec gh skill install $ORG/$SCRIPT_NAME-$RANDOM_STRING group-a/category-x/skills/skill-one --scope user --force
+stdout 'Installed skill-one'
+exists $HOME/.copilot/skills/skill-one/SKILL.md
+grep 'Skill One' $HOME/.copilot/skills/skill-one/SKILL.md
+
+# Install the deeply nested namespaced skill by direct path
+exec gh skill install $ORG/$SCRIPT_NAME-$RANDOM_STRING group-b/category-y/skills/team-alpha/skill-two --scope user --force
+stdout 'Installed team-alpha/skill-two'
+exists $HOME/.copilot/skills/team-alpha/skill-two/SKILL.md
+grep 'Skill Two' $HOME/.copilot/skills/team-alpha/skill-two/SKILL.md
+
+# Discovery by name (not path) also finds nested skills
+exec gh skill install $ORG/$SCRIPT_NAME-$RANDOM_STRING skill-one --force --dir $WORK/by-name
+stdout 'Installed skill-one'
+exists $WORK/by-name/skill-one/SKILL.md
+
+-- skill-one.md --
+---
+name: skill-one
+description: Skill One
+---
+
+# Skill One
+
+A nested skill discovered under a path prefix.
+
+-- skill-two.md --
+---
+name: skill-two
+description: Skill Two
+---
+
+# Skill Two
+
+A nested namespaced skill discovered under a path prefix.
diff --git a/acceptance/testdata/skills/skills-publish-dry-run.txtar b/acceptance/testdata/skills/skills-publish-dry-run.txtar
@@ -1,5 +1,6 @@
 # Publish dry-run from a directory with no skills/ should fail gracefully
-! exec gh skill publish --dry-run $WORK
+mkdir $WORK/empty-dir
+! exec gh skill publish --dry-run $WORK/empty-dir
 stderr 'no skills found in'
 
 # Publish dry-run against a valid skill directory should succeed
