paginate the defintions in the mongo store (fixes #254)#364
Merged
dabutvin merged 2 commits intoclearlydefined:masterfrom Jan 30, 2019
Merged
paginate the defintions in the mongo store (fixes #254)#364dabutvin merged 2 commits intoclearlydefined:masterfrom
dabutvin merged 2 commits intoclearlydefined:masterfrom
Conversation
jeffmcaffer
reviewed
Jan 30, 2019
Member
jeffmcaffer
left a comment
There was a problem hiding this comment.
A few things to check out but otherwise good to go
Member
|
Cool. Ship it when you get those changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For documents that have more than 1000 files, we will split them across different documents in the store.
This should be transparent to any callers of the store. we will get and set as one logical document.
Things to note:
_mongoproperty specific to this store and not surfaced as part of the definition