This repository was archived by the owner on May 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
This repository was archived by the owner on May 6, 2020. It is now read-only.
Define qemu build options *once* #339
Copy link
Copy link
Closed
Description
Currently, we have the qemu build (well configure) options scattered around the place:
- https://github.com/clearlinux-pkgs/qemu-lite/blob/master/configure
- https://github.com/clearcontainers/tests/blob/master/.ci/setup_env_ubuntu.sh
- https://github.com/clearcontainers/packaging/blob/master/qemu-lite/qemu-lite.spec
- https://github.com/clearcontainers/packaging/blob/master/qemu-lite/debian.rules
... and we're about to add:
- https://github.com/clearcontainers/packaging/blob/master/qemu-cc/qemu-cc.spec
- https://github.com/clearcontainers/packaging/blob/master/qemu-cc/debian.rules
This is not only confusing, it's potentially dangerous given some of the options relate to security.
There isn't much we can do about the clear linux build as that is a separate project, but for the remainder we need to define a single location these configure options live in.
Proposal
- Create https://github.com/clearcontainers/tests/tree/master/scripts/configure-hypervisor.sh
- Add each option on a separate line.
- Each option must have a comment explaining why it is being used.
- Make all repos and scripts that need to build
qemu/qemu-lite/qemu-cc/qemu-blah` run the script to determine the correct build options and thus guarantee the various builds are consistent.
Notes:
- this will be a change to the CI build which should mirror exactly how the packaged versions of
qemu*are built. - some consumers of the script will probably have to do a bit of work to import the output of this script (maybe by renaming config files to
file.inand adding a@HYPERVISOR_BUILD_OPTIONS@or similar intofile.in).
Reactions are currently unavailable