Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.
This repository was archived by the owner on May 6, 2020. It is now read-only.

Define qemu build options *once* #339

@jodh-intel

Description

@jodh-intel

Currently, we have the qemu build (well configure) options scattered around the place:

... and we're about to add:

This is not only confusing, it's potentially dangerous given some of the options relate to security.
There isn't much we can do about the clear linux build as that is a separate project, but for the remainder we need to define a single location these configure options live in.

Proposal

  1. Create https://github.com/clearcontainers/tests/tree/master/scripts/configure-hypervisor.sh
  2. Add each option on a separate line.
  3. Each option must have a comment explaining why it is being used.
  4. Make all repos and scripts that need to build qemu/qemu-lite/qemu-cc/qemu-blah` run the script to determine the correct build options and thus guarantee the various builds are consistent.

Notes:

  • this will be a change to the CI build which should mirror exactly how the packaged versions of qemu* are built.
  • some consumers of the script will probably have to do a bit of work to import the output of this script (maybe by renaming config files to file.in and adding a @HYPERVISOR_BUILD_OPTIONS@ or similar into file.in).

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions