cli: implement ps command by devimc · Pull Request #444 · clearcontainers/runtime

devimc · 2017-08-22T19:40:01Z

ps command is used by docker top to show
the processes running inside the container

partially fixes #95

Signed-off-by: Julio Montes julio.montes@intel.com

devimc · 2017-08-22T19:40:13Z

depends on containers/virtcontainers#269

clearcontainersbot · 2017-08-24T18:17:05Z

metrics-failed

clearcontainersbot · 2017-08-24T20:50:16Z

metrics-failed

clearcontainersbot · 2017-08-24T23:43:15Z

metrics-failed

clearcontainersbot · 2017-08-25T05:52:15Z

metrics-failed

clearcontainersbot · 2017-08-25T07:04:27Z

metrics-failed

clearcontainersbot · 2017-08-25T13:59:37Z

Popular Images qa-failed 👎

clearcontainersbot · 2017-08-28T15:48:45Z

Popular Images qa-failed 👎

clearcontainersbot · 2017-08-28T18:40:21Z

Popular Images qa-failed 👎

clearcontainersbot · 2017-09-26T07:28:38Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-10-03T08:30:45Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-10-04T10:16:29Z

kubernetes qa-failed 👎

jodh-intel · 2017-10-09T11:29:33Z

Still blocked on containers/virtcontainers#269.

clearcontainersbot · 2017-10-23T12:04:51Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-10-25T14:25:16Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-10-28T21:02:23Z

kubernetes qa-failed 👎

clearcontainersbot · 2017-10-30T09:36:03Z

kubernetes qa-failed 👎

sboeuf · 2017-10-30T14:46:02Z

@devimc please rebase this PR in order to get the CI properly running.

sboeuf

Looks good, but I would prefer the CLI params to be parsed before to call into ps()

sboeuf · 2017-10-30T16:52:43Z

ps.go

+	SkipArgReorder: true,
+}
+
+func ps(context *cli.Context) error {


I would prefer a function prototype like this:

func ps(containerID, format string) error {

since we could reuse this function. Also it is clearer to parse the arguments into the Action callback.

clearcontainersbot · 2017-10-30T17:42:48Z

kubernetes qa-passed 👍

devimc · 2017-10-30T18:10:45Z

@sboeuf changes applied

devimc · 2017-11-13T17:41:15Z

@jodh-intel cc-proxy was updated, can you please try again?

clearcontainersbot · 2017-11-13T18:25:39Z

kubernetes qa-passed 👍

jodh-intel · 2017-11-14T08:53:49Z

Still no joy I'm afraid:

$ sudo docker ps                                     
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
f91b2811adfc        busybox             "sh"                6 seconds ago       Up 3 seconds                            laughing_knuth
$ sudo cc-runtime list      
ID                                                                 PID         STATUS      BUNDLE                                                                                       CREATED                          OWNER
f91b2811adfc8d1ce315c26bfbcf930795c06a77a82a5a04cd05c082b1fa1b26   10685       running     /run/docker/libcontainerd/f91b2811adfc8d1ce315c26bfbcf930795c06a77a82a5a04cd05c082b1fa1b26   2017-11-14T08:47:09.121827607Z   #0
$ sudo cc-runtime ps f91b2811adfc8d1ce315c26bfbcf930795c06a77a82a5a04cd05c082b1fa1b26
ERROR received from VM agent

That (not terribly helpful) error seems to be coming from:

https://github.com/containers/virtcontainers/blob/master/pkg/hyperstart/hyperstart.go#L444

There isn't anything else useful in journald fwics.

clearcontainersbot · 2017-11-23T20:56:24Z

kubernetes qa-passed 👍

jodh-intel · 2017-11-27T11:45:50Z

I've just re-tested with latest runtime + latest agent but same problem :(

(It would be great to get this landed soon as I know how tricky it's been to add the required functionality to various parts of the system).

devimc · 2017-11-27T13:54:09Z

Hi @jodh-intel , still waiting for clearcontainers/agent#90

devimc · 2017-11-27T14:15:06Z

@jodh-intel it works for me

$ docker run -dti debian bash
264d40dd43f376b37dbd1af3783d9e6b2e2d0c0ec4d66111a6f6777c140e1ff0
$ sudo cc-runtime list
ID                                                                 PID         STATUS      BUNDLE                                                                                       CREATED                          OWNER
264d40dd43f376b37dbd1af3783d9e6b2e2d0c0ec4d66111a6f6777c140e1ff0   6166        running     /run/docker/libcontainerd/264d40dd43f376b37dbd1af3783d9e6b2e2d0c0ec4d66111a6f6777c140e1ff0   2017-11-27T14:12:53.493966351Z   #0
$ sudo cc-runtime ps 264d40dd43f376b37dbd1af3783d9e6b2e2d0c0ec4d66111a6f6777c140e1ff0
UID        PID  PPID  C STIME TTY          TIME CMD
root       163   146  0 14:12 ?        00:00:00 bash

probably we are doing something different

jodh-intel · 2017-11-28T15:35:36Z

I'm still seeing the problem with image 18860 and also using osbuilder + latest agent. I've tested with busybox and debian docker images. Could you try on another system, or else maybe someone else can try testing this?

devimc · 2017-11-28T16:03:36Z

Hi @jodh-intel

I'm using fedora + CL container image [1] + latest agent [2]

$ /usr/libexec/clear-containers/cc-proxy --version
Version: 3.0.8-2-g8bae402
$ /mnt/usr/bin/cc-agent --version
{"level":"info","msg":"","name":"cc-agent","pid":28094,"time":"2017-11-28T09:56:11.265027193-06:00","version":"0.1.1+-b1d92e2aa14d915680e8fe770745a511857ac7ff"}
{"level":"info","msg":"agent_started 329416.550221383","name":"cc-agent","pid":28094,"time":"2017-11-28T09:56:11.265258871-06:00"}
{"error":"open /sys/class/virtio-ports: no such file or directory","level":"error","msg":"Could not open channels","name":"cc-agent","pid":28094,"time":"2017-11-28T09:56:11.265343982-06:00"}
$ cc-runtime --version
cc-runtime  : 3.0.8
   commit   : b9c924320b05a6edeaefd8717aefee97df6aece3
   OCI specs: 1.0.0-dev
$ docker run -dti busybox sh
6f4155a11426e1daa6afb70f7c5ee367f235cf73ce666fc8d8eab19a19cc7497
$ sudo cc-runtime ps 6f4155a11426e1daa6afb70f7c5ee367f235cf73ce666fc8d8eab19a19cc7497
UID        PID  PPID  C STIME TTY          TIME CMD
root       164   148  0 15:56 ?        00:00:00 sh

btw osbuilder does not include ps (procps-ng-bin)

[1] - https://download.clearlinux.org/releases/18860/clear/clear-18860-containers.img.xz
[2] - https://github.com/clearcontainers/agent

clearcontainersbot · 2017-11-28T16:21:42Z

kubernetes qa-passed 👍

jodh-intel · 2017-11-28T16:44:16Z

I added the procps package (like clearcontainers/osbuilder#41), but I'm still seeing ERROR received from VM agent.

jodh-intel · 2017-12-05T10:48:33Z

After a rebase (required due to proxy changes), I am now getting the correct ps output! ;)

Could you rebase and we can get this merged?

devimc · 2017-12-05T13:40:57Z

@jodh-intel great! thanks

clearcontainersbot · 2017-12-05T14:01:20Z

kubernetes qa-passed 👍

jodh-intel · 2017-12-06T16:25:26Z

ps.go

+
+	var options vc.ProcessListOptions
+
+	// [1:] is to remove command name, ex:


Has this comment become detached from the code (line 43?)

jodh-intel · 2017-12-06T16:25:37Z

ps.go

+	var options vc.ProcessListOptions
+
+	// [1:] is to remove command name, ex:
+	// context.Args(): [containet_id ps_arg1 ps_arg2 ...]


typo: container_id.

fixed, thanks

jodh-intel · 2017-12-06T16:26:06Z

Hi @devimc - could you re-push? The CI seems to have got confused.

jodh-intel · 2017-12-06T16:26:29Z

err - it just updated as I was typing! ;)

ps command is used by ```docker top``` to show the processes running inside the container partially fixes clearcontainers#95 Signed-off-by: Julio Montes <julio.montes@intel.com>

devimc · 2017-12-06T17:42:43Z

@jodh-intel changes applied, thanks

clearcontainersbot · 2017-12-06T18:27:03Z

kubernetes qa-passed 👍

jodh-intel · 2017-12-07T08:35:28Z

lgtm

jodh-intel · 2017-12-07T08:36:21Z

Coveralls is stuck (surprise!) - https://coveralls.io/jobs/31802016.

Merging...

devimc added the in progress label Aug 22, 2017

devimc added the do-not-merge label Aug 22, 2017

clearcontainers deleted a comment from clearcontainersbot Aug 23, 2017

devimc force-pushed the topic/psCommand branch from 7217289 to b8ec3ee Compare August 28, 2017 18:39

devimc force-pushed the topic/psCommand branch from b8ec3ee to 4389db1 Compare October 25, 2017 14:16

devimc force-pushed the topic/psCommand branch 2 times, most recently from 960371d to f1d3620 Compare October 30, 2017 15:47

devimc removed the do-not-merge label Oct 30, 2017

sboeuf reviewed Oct 30, 2017

View reviewed changes

devimc force-pushed the topic/psCommand branch from f1d3620 to 1586053 Compare October 30, 2017 18:10

devimc force-pushed the topic/psCommand branch from abdef2e to abe3e85 Compare November 13, 2017 17:39

devimc force-pushed the topic/psCommand branch from abe3e85 to b9c9243 Compare November 28, 2017 15:50

jodh-intel mentioned this pull request Dec 5, 2017

packages: add procps-ng-bin package clearcontainers/osbuilder#41

Merged

devimc force-pushed the topic/psCommand branch from b9c9243 to 2cb8855 Compare December 5, 2017 13:40

jodh-intel reviewed Dec 6, 2017

View reviewed changes

cli: implement ps command

f74d69e

ps command is used by ```docker top``` to show the processes running inside the container partially fixes clearcontainers#95 Signed-off-by: Julio Montes <julio.montes@intel.com>

devimc force-pushed the topic/psCommand branch from 2cb8855 to f74d69e Compare December 6, 2017 17:42

jodh-intel merged commit 95937d6 into clearcontainers:master Dec 7, 2017

jodh-intel removed the in progress label Dec 7, 2017


		var options vc.ProcessListOptions

		// [1:] is to remove command name, ex:

Conversation

devimc commented Aug 22, 2017

Uh oh!

devimc commented Aug 22, 2017

Uh oh!

clearcontainersbot commented Aug 24, 2017

Uh oh!

clearcontainersbot commented Aug 24, 2017

Uh oh!

clearcontainersbot commented Aug 24, 2017

Uh oh!

clearcontainersbot commented Aug 25, 2017

Uh oh!

clearcontainersbot commented Aug 25, 2017

Uh oh!

clearcontainersbot commented Aug 25, 2017

Uh oh!

clearcontainersbot commented Aug 28, 2017

Uh oh!

clearcontainersbot commented Aug 28, 2017

Uh oh!

clearcontainersbot commented Sep 26, 2017

Uh oh!

clearcontainersbot commented Oct 3, 2017

Uh oh!

clearcontainersbot commented Oct 4, 2017

Uh oh!

jodh-intel commented Oct 9, 2017

Uh oh!

clearcontainersbot commented Oct 23, 2017

Uh oh!

clearcontainersbot commented Oct 25, 2017

Uh oh!

clearcontainersbot commented Oct 28, 2017

Uh oh!

clearcontainersbot commented Oct 30, 2017

Uh oh!

sboeuf commented Oct 30, 2017

Uh oh!

sboeuf left a comment

Choose a reason for hiding this comment

Uh oh!

sboeuf Oct 30, 2017

Choose a reason for hiding this comment

Uh oh!

clearcontainersbot commented Oct 30, 2017

Uh oh!

devimc commented Oct 30, 2017

Uh oh!

devimc commented Nov 13, 2017

Uh oh!

clearcontainersbot commented Nov 13, 2017

Uh oh!

jodh-intel commented Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clearcontainersbot commented Nov 23, 2017

Uh oh!

jodh-intel commented Nov 27, 2017

Uh oh!

devimc commented Nov 27, 2017

Uh oh!

devimc commented Nov 27, 2017

Uh oh!

jodh-intel commented Nov 28, 2017

Uh oh!

devimc commented Nov 28, 2017

Uh oh!

clearcontainersbot commented Nov 28, 2017

Uh oh!

jodh-intel commented Nov 28, 2017

Uh oh!

jodh-intel commented Dec 5, 2017

Uh oh!

devimc commented Dec 5, 2017

Uh oh!

clearcontainersbot commented Dec 5, 2017

Uh oh!

jodh-intel Dec 6, 2017

Choose a reason for hiding this comment

jodh-intel commented Nov 14, 2017 •

edited

Loading

jodh-intel commented Dec 7, 2017 •

edited by grahamwhaley

Loading