This repository was archived by the owner on May 6, 2020. It is now read-only.
Forward hyperstart response to clients#83
Merged
dlespiau merged 5 commits intoclearcontainers:masterfrom Jun 26, 2017
Merged
Conversation
added 5 commits
June 24, 2017 19:35
This comment if from a time this type was prefixed with "proto", this is not the case any more. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Until now, we could only return JSON payloads and AddResult only allowed to key (key, JSON snippet) pairs. SetData can now be used to specify the full payload to send back to the client. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
We didn't have the need for response data until now. We were only receiving Ok/NotOk messages back from the agent. We'll need this for the new PS command Julio wants to implement. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
We can now receive data as part of the hyperstart response and we forward it to clients. Fixes: clearcontainers#72 Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
It seems that gofmt now removes the space before this string concatenation. So be it. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
|
lgtm |
|
LGTM
|
|
Related: clearcontainers/runtime#95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, hyperstart was never sending data along with the response to commands we cared about. Julio wants to add a ps message that will send some data back though, so let's support that.
We can probably do nice things in the new agent with this as well