This repository was archived by the owner on May 6, 2020. It is now read-only.
agent: read full data from ctl and tty channels#202
Merged
amshinde merged 1 commit intoclearcontainers:masterfrom Jan 27, 2018
Merged
agent: read full data from ctl and tty channels#202amshinde merged 1 commit intoclearcontainers:masterfrom
amshinde merged 1 commit intoclearcontainers:masterfrom
Conversation
|
Hi @devimc - looks fine, but please can you add some tests for |
Author
|
@jodh-intel I always forget to write unit tests 😄 , lemme write them |
Contributor
|
... which is odd because you are really good at writing them! 😄 Thanks. |
Author
|
@jodh-intel changes applied, thanks |
jodh-intel
reviewed
Jan 25, 2018
agent_test.go
Outdated
| t.Error(err) | ||
| } | ||
| if uint32(n) != uint32(ctlHeaderSize) { | ||
| t.Error("expected: %d, actual: %d", n, ctlHeaderSize) |
There was a problem hiding this comment.
Travis is failing as the linters have detected this and a few other calls should be t.Errorf().
this patch is to read all the data sent by the proxy and to avoid error reading more than 4096 bytes fixes clearcontainers#201 Signed-off-by: Julio Montes <julio.montes@intel.com>
jodh-intel
approved these changes
Jan 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch is to read all the data sent by the proxy and to avoid
error reading more than 4096 bytes
fixes #201
Signed-off-by: Julio Montes julio.montes@intel.com