Update readme to replace --level option with -O#68
Merged
jakubpawlowicz merged 1 commit intoclean-css:masterfrom May 5, 2021
Merged
Update readme to replace --level option with -O#68jakubpawlowicz merged 1 commit intoclean-css:masterfrom
--level option with -O#68jakubpawlowicz merged 1 commit intoclean-css:masterfrom
Conversation
This change removes mention of the `--level` option which never existed. In versions earlier than 5.0.0, clean-css-cli used to accept the invalid option silently. With versions > 5.0.0, trying to use the option results in the following: `error: unknown option '--level'`. The root cause of the change the upgrade to [commander v7.0.0](tj/commander.js#1409), where unknown (excess) command arguments are now raised as an error.
--level option with -O
Collaborator
|
Hi @davidjb - many thanks for spotting this! You are right, there were never a |
Contributor
Author
|
No problem @jakubpawlowicz - I had to go digging to understand what happened on upgrading from v4 to v5..and turns out it was never there at all 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes mention of the
--leveloption which never existed. In versions earlier than 5.0.0, clean-css-cli used to accept the invalid option silently. With versions > 5.0.0, trying to use the option results in the following:error: unknown option '--level'. The root cause of the change the upgrade to commander v7.0.0, where unknown (excess) command arguments are now raised as an error.For interest, I was using the option because Bootstrap previously used it in their package.json.