Skip to content

Update CI#50

Merged
jakubpawlowicz merged 1 commit intoclean-css:masterfrom
XhmikosR:patch-2
Feb 10, 2021
Merged

Update CI#50
jakubpawlowicz merged 1 commit intoclean-css:masterfrom
XhmikosR:patch-2

Conversation

@XhmikosR
Copy link
Copy Markdown
Contributor

@XhmikosR XhmikosR commented Feb 10, 2021 •
edited
Loading

  • specify fail-fast: false
  • update to actions/setup-node@v2
  • fix indentation

@XhmikosR
Update CI
7bf78ce 
* specify `fail-fast: false`
* update to `actions/setup-node@v2`
* fix indentation
@XhmikosR XhmikosR mentioned this pull request Feb 10, 2021
Merged
@jakubpawlowicz jakubpawlowicz merged commit 7fe2128 into clean-css:master Feb 10, 2021
@XhmikosR XhmikosR deleted the patch-2 branch February 10, 2021 14:00
@XhmikosR
Copy link
Copy Markdown
Contributor Author

XhmikosR commented Feb 10, 2021

@jakubpawlowicz we should probably run at least one version on Windows too. And/or update the readme line that says tested on Linux, OS X, and Windows

@jakubpawlowicz
Copy link
Copy Markdown
Collaborator

jakubpawlowicz commented Feb 10, 2021

Yes we should. I can no longer test on OS X so I've just removed that. Re tests on Windows we should set it up.

@XhmikosR
Copy link
Copy Markdown
Contributor Author

XhmikosR commented Feb 10, 2021

You can test OS X and Windows with Actions just fine :)

The easy way would be to just run the whole thing on all OS'es, even though it might be redundant running 4 Node.js version x 3 OS'es = 12 Actions.

@jakubpawlowicz
Copy link
Copy Markdown
Collaborator

jakubpawlowicz commented Feb 10, 2021

I wasn't aware Actions support it. I wouldn't mind running them on Node.js 14 on OS X and Windows and the rest of them on Linux. Thoughts?

@XhmikosR
Copy link
Copy Markdown
Contributor Author

XhmikosR commented Feb 10, 2021

Sounds good to me. I'll see if I can put something together in the next days and if we have a solid workflow file you can backport it to clean-css too.

@jakubpawlowicz
Copy link
Copy Markdown
Collaborator

jakubpawlowicz commented Feb 10, 2021

Thanks, much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @jakubpawlowicz