Skip to content

Rename endian codec#18

Merged
clbarnes merged 11 commits intomainfrom
rename_endian
Nov 2, 2023
Merged

Rename endian codec#18
clbarnes merged 11 commits intomainfrom
rename_endian

Conversation

@clbarnes
Copy link
Copy Markdown
Owner

Following this PR zarr-developers/zarr-specs#263

Also allows the endianness to be undefined for single-byte dtypes.
@clbarnes
Copy link
Copy Markdown
Owner Author

clbarnes commented Oct 31, 2023

To do: improve error handling here. Maybe AB codecs need an endian() method, which ArrayMetadata can access through the CodecChain and check against the dtype - then it's justifiable to leave the undefined endianness at the codec level as a panic rather than making it fallible.

Or this all becomes fine anyway as codec ops probably need to be fallible anyway.

@clbarnes
Copy link
Copy Markdown
Owner Author

clbarnes commented Nov 1, 2023

Added validation of endianness on arraymetadata construction.

@clbarnes
Copy link
Copy Markdown
Owner Author

clbarnes commented Nov 1, 2023

Also updates for recent spec changes:

  • Remove C and F from transpose codec
  • Remove fallback types

@clbarnes clbarnes merged commit eb2137e into main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant