[Issue 920] Updating getMethodInfo to not get superconstructors #921
+40
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e301a2 to
b6427d8
Compare
b6427d8 to
fbe61e0
Compare
Member
|
Good catch, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClassGraph returns the MethodInfo of some (but not all!) superclass constructors when asked for a Class's constructors.
Particularly confusing for users if there's a non-public constructor with the same signature as a constructor in the superclass and
.ignoreMethodVisibility()isn't set. This is the only case where an overridden method is returned fromgetMethodInfo()and is because constructors are the only case where a method can have the same signature as a superclass method, but have lower visibility.Issue link