Add UWP template #2
Conversation
| project (runner LANGUAGES CXX) | ||
|
|
||
| # UWP tile and icon assets. | ||
| set(ASSET_FILES ${ASSET_FILES} |
There was a problem hiding this comment.
To avoid including this in the git repo history, we can upload them to the flutter_template_images package: https://pub.dev/packages/flutter_template_images
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM, but we'll need to move the assets before we do the final upload to the git repo
| set(APP_MANIFEST_NAME Package.appxmanifest) | ||
| set(APP_MANIFEST_TARGET_LOCATION ${CMAKE_CURRENT_BINARY_DIR}/${APP_MANIFEST_NAME}) | ||
| set(SHORT_NAME ${BINARY_NAME}) | ||
| set(PACKAGE_GUID "F941A77F-8AE1-4E3E-9611-68FBD3C62AE8") |
There was a problem hiding this comment.
We'll want to replace this with {{packageGUID}}:
set(PACKAGE_GUID "{{packageGUID}}")
There was a problem hiding this comment.
When you do that, this file will need to be renamed CMakeLists.txt.tmpl
There was a problem hiding this comment.
I would prefer not to break this from working standalone as part of the review.. maybe can do that in a branch or as part of the porting?
src/winuwp/project_version
Outdated
| @@ -0,0 +1 @@ | |||
| 0 No newline at end of file | |||
There was a problem hiding this comment.
Here and a few other places: add a trailing newline at the end of these files.
There was a problem hiding this comment.
which other places? ;-)
src/winuwp/runner_uwp/CMakeLists.txt
Outdated
| target_link_libraries(${BINARY_NAME} PRIVATE WindowsApp flutter flutter_wrapper_app) | ||
| target_include_directories(${BINARY_NAME} PRIVATE "${CMAKE_SOURCE_DIR}") | ||
|
|
||
| add_dependencies(${BINARY_NAME} flutter_assemble) No newline at end of file |
There was a problem hiding this comment.
Add a trailing newline for each of the files below this.
| flutter_view_controller_ = std::make_unique<flutter::FlutterViewController>( | ||
| static_cast<ABI::Windows::ApplicationModel::Core::CoreApplicationView*>(winrt::get_abi(main_view_)), | ||
| static_cast<ABI::Windows::ApplicationModel::Activation::IActivatedEventArgs*>(winrt::get_abi(launch_args_)), | ||
| project); |
There was a problem hiding this comment.
The formatting for lines 112-116 looks wrong.
Stripped all but UWP template files