Fix insufficient contrast ratio for links in notifications#5496
Merged
jacekbogdanski merged 3 commits intomasterfrom Jun 23, 2023
Merged
Fix insufficient contrast ratio for links in notifications#5496jacekbogdanski merged 3 commits intomasterfrom
jacekbogdanski merged 3 commits intomasterfrom
Conversation
jacekbogdanski
approved these changes
Jun 23, 2023
Member
jacekbogdanski
left a comment
There was a problem hiding this comment.
I've removed 5a4f216 to avoid potential breaking changes in this PR for some integrators.
Other than that, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
I've forced inherited font color for links inside notifications. It seems that the current link color was inherited (pun not intended) from the
kamaskin.Additionally, commit 5a4f216 contains further (more aggressive) contrast enhancements, involving changing backgrounds of the notifications in the
moonoandmoono-lisaskins (kamahas already good contrast ratio).Which issues does your PR resolve?
Closes #5495.