Fix incorrect selection handling in the Rich Combos#5478
Fix incorrect selection handling in the Rich Combos#5478KarolDawidziuk merged 5 commits intomasterfrom
Conversation
|
It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days. |
|
As the "Styles" combo seems to work well even without the fix, I've updated tests to use the "Font" one. Additionally I've rebased the PR onto the latest |
KarolDawidziuk
left a comment
There was a problem hiding this comment.
Hi @Comandeer
Good job on removing the unnecessary method, therefore, improving selection handling in the Rich Combos. 👏
There is one place that we must update as this method no longer exist.
https://github.com/ckeditor/ckeditor4/blob/master/plugins/floatpanel/plugin.js#L427-L430
This shortened if statement is no longer valid and we can simplify it to just:
if ( CKEDITOR.env.ie ) {
CKEDITOR.tools.setTimeout( function() {
block._.markFirstDisplayed();
}, 0 );
} else {
block._.markFirstDisplayed();
}Could you update it, please?
|
It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days. |
|
After F2F with @KarolDawidziuk we decided to keep the conditional in the same shape to ensure the highest backward compatibility with potential custom marking logic for panels. |
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
I've discovered that we have a whole logic to apply the
[aria-selected]attribute in place. However, the selected item was unmarked upon each opening of the combobox due to an incorrectly applied fix to an old accessibility issue. It was supposed to ensure that after opening the context menu, the first item will be focused. However, as comboboxes are not context menus and their keyboard interaction pattern is quite different, I simply removed the old fix.As a bonus, we now have also correct styling of the selected items in comboboxes 🎉
Which issues does your PR resolve?
Closes #5437.