Merged
Conversation
Owner
|
@PurpleBabar This looks good at first glance. Let me look over this in a bit more detail over the next day or two and I'll merge it and start publishing to my own docker repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey :)
Thanks for the amazing tool, I bumped some versions and added docker support :)
to run it at the moment use:
docker run -d --rm -p 80:80 lumberjackotters/visualsubnetcalc:latestThere is also a github action workflow so you can build the container and push it to dockerhub (with your username in it :))
Do you want me to update documentation ?
Cheerz
PurpleBabar