Skip to content

Docker improvements#12

Merged
ckabalan merged 2 commits intockabalan:developfrom
byroncollins:feature/docker-improvements
Feb 4, 2025
Merged

Docker improvements#12
ckabalan merged 2 commits intockabalan:developfrom
byroncollins:feature/docker-improvements

Conversation

@byroncollins
Copy link
Contributor

  • Added documentation for running the application as a docker container
  • reorganised dockerfile to improve cache utilisation
  • Moved the application base image to a non privileged container (running in a non-root user and on a unprivileged port). Most Enterprise kubernetes distributions restrict containers by default from running as root and using privileged ports.
  • Exposed port changed from 80 to 8080
  • Modified github actions to build new container when a new git tag is created( new release)
  • Updated ASzc/change-string-case-action to v6 to resolve issue with action running unsupported nodejs version.

Would recommend also updating the overview on https://hub.docker.com/r/ckabalan/visualsubnetcalc.

closes #9

@ckabalan ckabalan changed the base branch from main to develop February 4, 2025 03:48
@ckabalan ckabalan merged commit b3df034 into ckabalan:develop Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to add install instructions for Docker

2 participants