Conversation
- Modified list() function to parse YAML files and extract actual session names - Added graceful error handling for malformed YAML files with warnings - Updated session manager to handle spaces in session names by converting to dashes - Removed unnecessary quotes from tmux session name display - Added .devenv to VSCode exclusions - Updated related tests to match tmux client changes
- Update config file path construction to replace spaces in names with hyphens - Adjust edit and delete operations to use normalized file names for consistency - Ensure all config file interactions handle names with spaces correctly
- Replace array creation with from_ref to pass single error reference - Improve error handling in build_error_tree for array field errors
dd4a7eb to
42d804a
Compare
- Introduce ConfigNameExt trait with sanitize method for consistent config name formatting - Replace ad-hoc string replacements with sanitize method in config and session managers - Extend sanitization to replace spaces and underscores with hyphens, enforce lowercase, and filter non-alphanumeric characters except hyphens - Update imports to include ConfigNameExt where required
42d804a to
ac0032f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the user experience when listing configurations by showing the actual session names from YAML files instead of just the filenames.
Changes
Core Feature
list()function inConfigManagerto parse YAML files and extract actual session namesRelated Improvements
.devenvto VSCode exclusions for better development environmentBenefits
Testing
Result<Vec<String>>)