Fix broken tests and only put certificates in the X509Certificate element#1
Fix broken tests and only put certificates in the X509Certificate element#1cjbarth merged 10 commits intocjbarth:key-infofrom shunkica:key-info
Conversation
|
It still seems there is some kind of race condition or scoping issue regarding the static SignatureAlgorithm member when running the tests. Sometimes they pass sometimes they fail, it is arbitrary. When they fail, the value of SignedXml.SignatureAlgorithms is {}, even though it is never set to an empty object. |
…ms instance members of SignedXml
|
Making SignatureAlgorithms, HashAlgorithms and CanonicalizationAlgorithms instance members of SignedXml, made sense, and it also had the side effect of fixing the issues with the tests. |
|
Since the With this commit all the tests are passing. |
|
Here is a theoretical untested function for extracting public keys and their respective types: And then in getKeyInfoContent: However, this does not fall into the scope of this PR so I do not want to work on this any further right now. |
This will fix the tests which are broken, but I still think that the algorithms should be an instance member, as opposed to static.