feat: Introduce --no-default-rules flag, deprecate --create-rules #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue in #446
In here, I,
--no-default-rulesflag to control default firewall rule creation.--create-rulesas deprecated but kept for backward compatibility.--create-rulesusage.Why deprecate
--create-rulesflag ?If we see the documentation, it seems
--create-ruleswas introduced to give users a way to create firewalls without any default firewall rules set.But, now that we have
--no-default-rulesflag, deprecating (not removing)--create-rulesI feel is the obvious next step here.Result:
--create-rulesflag2.When we use
--create-rulesflag, a warning message flashes, but default rule still gets created as before.--no-default-rules--no-default-rulesflag