fix: BCH's Pubkey/Schnorr signature detection in inputs#395
Merged
maltemoeser merged 1 commit intocitp:v0.6from Apr 15, 2020
Merged
fix: BCH's Pubkey/Schnorr signature detection in inputs#395maltemoeser merged 1 commit intocitp:v0.6from
maltemoeser merged 1 commit intocitp:v0.6from
Conversation
Member
Author
|
Laut integrity check ist das parsing mit meinem patch identisch zu deinem: https://gist.github.com/maltemoeser/82810ee894ac7d40d8a0912591f3fb4d |
BREAKING CHANGE: Reparsing existing BCH parsings is strongly recommended. This fixes that BCH's new Schnorr signatures are erroneously detected as public keys because both can have a length of 65 bytes. Based on mplattner@910dade
7e62b6b to
0b7a723
Compare
mplattner
approved these changes
Apr 15, 2020
Collaborator
mplattner
left a comment
There was a problem hiding this comment.
Looks good to me, can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Reparsing existing BCH parsings is strongly recommended.
This fixes that BCH's new Schnorr signatures are erroneously detected as public keys because both can have a length of 65 bytes.
Based on mplattner@910dade